[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/16] hw/misc/applesmc: Fix memory leak in reset() handler
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL 10/16] hw/misc/applesmc: Fix memory leak in reset() handler |
Date: |
Wed, 10 Apr 2024 11:13:09 +0200 |
AppleSMCData is allocated with g_new0() in applesmc_add_key():
release it with g_free().
Leaked since commit 1ddda5cd36 ("AppleSMC device emulation").
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240408095217.57239-3-philmd@linaro.org>
---
hw/misc/applesmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index 8e65816da6..14e3ef667d 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -274,6 +274,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
/* Remove existing entries */
QLIST_FOREACH_SAFE(d, &s->data_def, node, next) {
QLIST_REMOVE(d, node);
+ g_free(d);
}
s->status = 0x00;
s->status_1e = 0x00;
--
2.41.0
- [PULL 00/16] Misc HW patches for 2024-04-10, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 01/16] hw/virtio: Introduce virtio_bh_new_guarded() helper, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 02/16] hw/display/virtio-gpu: Protect from DMA re-entrancy bugs, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 04/16] hw/virtio/virtio-crypto: Protect from DMA re-entrancy bugs, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 03/16] hw/char/virtio-serial-bus: Protect from DMA re-entrancy bugs, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 05/16] qemu-options: Fix CXL Fixed Memory Window interleave-granularity typo, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 06/16] hw/block/nand: Factor nand_load_iolen() method out, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 07/16] hw/block/nand: Have blk_load() take unsigned offset and return boolean, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 08/16] hw/block/nand: Fix out-of-bound access in NAND block buffer, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 09/16] hw/misc/applesmc: Do not call DeviceReset from DeviceRealize, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 10/16] hw/misc/applesmc: Fix memory leak in reset() handler,
Philippe Mathieu-Daudé <=
- [PULL 11/16] backends/cryptodev: Do not abort for invalid session ID, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 12/16] hw/net/lan9118: Replace magic '2048' value by MIL_TXFIFO_SIZE definition, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 13/16] hw/net/lan9118: Fix overflow in MIL TX FIFO, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 14/16] hw/sd/sdhci: Do not update TRNMOD when Command Inhibit (DAT) is set, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 16/16] hw/audio/virtio-snd: Remove unused assignment, Philippe Mathieu-Daudé, 2024/04/10
- [PULL 15/16] hw/net/net_tx_pkt: Fix overrun in update_sctp_checksum(), Philippe Mathieu-Daudé, 2024/04/10
- Re: [PULL 00/16] Misc HW patches for 2024-04-10, Peter Maydell, 2024/04/10