Re: [PULL 1/4] edk2: get version + date from git submodule

[Peter Maydell]

On Tue, 9 Apr 2024 at 19:02, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 09.04.2024 19:29, Gerd Hoffmann:
> > +efi: edk2-version
> >       $(PYTHON) edk2-build.py --config edk2-build.config \
> > -             --version-override "edk2-stable202302-for-qemu" \
> > -             --release-date "03/01/2023"
> > +             --version-override "$(EDK2_STABLE)-for-qemu" \
> > +             --release-date "$(EDK2_DATE)" \
>
> How it will look like if there's no edk2/.git, for example, when run in
> extracted release tarball, with empty EDK2_STABLE and EKD2_DATE?
>
> Should these values be a part of release tarball maybe?
> Or maybe it's better to base EKD2_{DATE|VERSION} on qemu date/version in
> this case?

Patch 2 commits the edk2-version file, so it should end up
in the release tarball that way. (Effectively it becomes an
output of the "build the roms" process, same as the edk2 blobs
themselves.)

thanks
-- PMM