[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/14] migration: Plug memory leak on HMP migrate error path
From: |
peterx |
Subject: |
[PULL 02/14] migration: Plug memory leak on HMP migrate error path |
Date: |
Mon, 29 Jan 2024 11:03:53 +0800 |
From: Markus Armbruster <armbru@redhat.com>
hmp_migrate() leaks @caps when qmp_migrate() fails. Plug the leak
with g_autoptr().
Fixes: 967f2de5c9ec (migration: Implement MigrateChannelList to hmp migration
flow.) v8.2.0-rc0
Fixes: CID 1533125
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Link: 20240117140722.3979657-1-armbru@redhat.com">https://lore.kernel.org/r/20240117140722.3979657-1-armbru@redhat.com
[peterx: fix CID number as reported by Peter Maydell]
Signed-off-by: Peter Xu <peterx@redhat.com>
---
migration/migration-hmp-cmds.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c
index 740a219aa4..99b49df5dd 100644
--- a/migration/migration-hmp-cmds.c
+++ b/migration/migration-hmp-cmds.c
@@ -764,7 +764,7 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
bool resume = qdict_get_try_bool(qdict, "resume", false);
const char *uri = qdict_get_str(qdict, "uri");
Error *err = NULL;
- MigrationChannelList *caps = NULL;
+ g_autoptr(MigrationChannelList) caps = NULL;
g_autoptr(MigrationChannel) channel = NULL;
if (inc) {
@@ -789,8 +789,6 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
return;
}
- qapi_free_MigrationChannelList(caps);
-
if (!detach) {
HMPMigrationStatus *status;
--
2.43.0
- [PULL 00/14] Migration 20240126 patches, peterx, 2024/01/28
- [PULL 01/14] userfaultfd: use 1ULL to build ioctl masks, peterx, 2024/01/28
- [PULL 02/14] migration: Plug memory leak on HMP migrate error path,
peterx <=
- [PULL 03/14] migration: Make threshold_size an uint64_t, peterx, 2024/01/28
- [PULL 05/14] analyze-migration.py: Remove trick on parsing ramblocks, peterx, 2024/01/28
- [PULL 04/14] migration: Drop unnecessary check in ram's pending_exact(), peterx, 2024/01/28
- [PULL 06/14] ci: Add a migration compatibility test job, peterx, 2024/01/28
- [PULL 07/14] ci: Disable migration compatibility tests for aarch64, peterx, 2024/01/28
- [PULL 08/14] migration/yank: Use channel features, peterx, 2024/01/28
- [PULL 09/14] migration: Fix use-after-free of migration state object, peterx, 2024/01/28
- [PULL 10/14] migration: Take reference to migration state around bg_migration_vm_start_bh, peterx, 2024/01/28
- [PULL 11/14] migration: Reference migration state around loadvm_postcopy_handle_run_bh, peterx, 2024/01/28
- [PULL 12/14] migration: Add a wrapper to qemu_bh_schedule, peterx, 2024/01/28