Re: [PATCH v2 3/5] hw/arm/aspeed: Init CPU defaults in a common helper

[Philippe Mathieu-Daudé]

On 25/1/24 03:26, Gavin Shan wrote:
> Hi Phil,
>
> On 1/24/24 08:48, Philippe Mathieu-Daudé wrote:
> > Rework aspeed_soc_num_cpus() as a new init_cpus_defaults()
> > helper to reduce code duplication.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   hw/arm/aspeed.c | 71 +++++++++++++++++++------------------------------
> >   1 file changed, 28 insertions(+), 43 deletions(-)
>
> One nit needs to be addressed:
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>


> Failure from './scripts/checkpatch.pl --strict'
>
> ERROR: do not use C99 // comments
> #216: FILE: hw/arm/aspeed.c:1505:
> +    aspeed_machine_class_init_cpus_defaults(mc); //

Oops, forgot to clean that =) Thanks!