Re: [PATCH] qemu-docs: Update options for graphical frontends

[Michael Tokarev]

18.01.2024 09:39, Yihuan Pan :
> The command line options `-ctrl-grab` and `-alt-grab` have been removed
> in QEMU 7.1. Instead, use the `-display sdl,grab-mod=<modifiers>` option
> to specify the grab modifiers.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2103
> Signed-off-by: Yihuan Pan <xun794@gmail.com>
> ---
>   docs/system/keys.rst.inc | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc
> index bd9b8e5f6f..44698e301e 100644
> --- a/docs/system/keys.rst.inc
> +++ b/docs/system/keys.rst.inc
> @@ -1,7 +1,8 @@
>   During the graphical emulation, you can use special key combinations to
>   change modes. The default key mappings are shown below, but if you use
> -``-alt-grab`` then the modifier is Ctrl-Alt-Shift (instead of Ctrl-Alt)
> -and if you use ``-ctrl-grab`` then the modifier is the right Ctrl key
> +``-display sdl,grab-mod=lshift-lctrl-lalt`` then the modifier is
> +Ctrl-Alt-Shift(instead of Ctrl-Alt) and if you use
> +``-display sdl,grab-mod=rctrl`` then the modifier is the right Ctrl key
>   (instead of Ctrl-Alt):

A nitpick: please add space before "(instead".

But the whole sentence wants some refinement, or else it is awkward at
best.  How about something like,

   During the graphical emulation, you can use special key combinations from
   the following table to change modes. By default the modifier is Ctrl-Alt
   (used in the table below), which can be changed with ``-display`` suboption
   ``mod=`` where appropriate.  For example, ``-display 
sdl,grab-mod=lshift-lctrl-lalt``
   changes the modifier key to Ctrl-Alt-Shift, while ``-display sdl, 
grab-mod=rctrl``
   changes it to the right Ctrl key.

?

Thanks,

/mjt

>   
>   Ctrl-Alt-f