Re: [PATCH-for-9.0 03/16] target/arm/kvm: Have kvm_arm_add_vcpu_properties take a ARMCPU argument

[Philippe Mathieu-Daudé]

On 27/11/23 05:05, Gavin Shan wrote:
> Hi Phil,
>
> On 11/24/23 05:35, Philippe Mathieu-Daudé wrote:
> > Unify the "kvm_arm.h" API: All functions related to ARM vCPUs
> > take a ARMCPU* argument. Use the CPU() QOM cast macro When
> > calling the generic vCPU API from "sysemu/kvm.h".
> >
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> > ---
> >   target/arm/kvm_arm.h | 4 ++--
> >   target/arm/cpu.c     | 2 +-
> >   target/arm/kvm.c     | 4 ++--
> >   3 files changed, 5 insertions(+), 5 deletions(-)
>
> With the following comments resolved:
>
> Reviewed-by: Gavin Shan <gshan@redhat.com>
>
> > diff --git a/target/arm/kvm_arm.h b/target/arm/kvm_arm.h
> > index 50967f4ae9..6fb8a5f67e 100644
> > --- a/target/arm/kvm_arm.h
> > +++ b/target/arm/kvm_arm.h
> > @@ -153,7 +153,7 @@ void kvm_arm_set_cpu_features_from_host(ARMCPU *cpu);
> >    * Add all KVM specific CPU properties to the CPU object. These
> >    * are the CPU properties with "kvm-" prefixed names.
> >    */
> > -void kvm_arm_add_vcpu_properties(Object *obj);
> > +void kvm_arm_add_vcpu_properties(ARMCPU *cpu);
>
> The function's description needs to be modified since @obj has been
> renamed to @cpu?
>
>    /**
>     * kvm_arm_add_vcpu_properties:
>     * @obj: The CPU object to add the properties to
>     *
>     */

Oops thanks!