[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directo
From: |
Stefano Stabellini |
Subject: |
Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory |
Date: |
Wed, 22 Nov 2023 15:09:10 -0800 (PST) |
User-agent: |
Alpine 2.22 (DEB 394 2020-01-19) |
On Wed, 22 Nov 2023, David Woodhouse wrote:
> On Wed, 2023-11-22 at 14:29 -0800, Stefano Stabellini wrote:
> > On Wed, 22 Nov 2023, Paul Durrant wrote:
> > > On 21/11/2023 22:10, Volodymyr Babchuk wrote:
> > > > From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>
> > > >
> > > > Instead of forcing the owner to domid 0, use XS_PRESERVE_OWNER to
> > > > inherit the owner of the directory.
> > >
> > > Ah... so that's why the previous patch is there.
> > >
> > > This is not the right way to fix it. The QEMU Xen support is *assuming*
> > > that
> > > QEMU is either running in, or emulating, dom0. In the emulation case this
> > > is
> > > probably fine, but the 'real Xen' case it should be using the correct
> > > domid
> > > for node creation. I guess this could either be supplied on the command
> > > line
> > > or discerned by reading the local domain 'domid' node.
> >
> > yes, it should be passed as command line option to QEMU
>
> I'm not sure I like the idea of a command line option for something
> which QEMU could discover for itself.
That's fine too. I meant to say "yes, as far as I know the toolstack
passes the domid to QEMU as a command line option today".
- Re: [PATCH v2 2/6] xen: backends: touch some XenStore nodes only if device..., (continued)
- [PATCH v2 5/6] xen_arm: Set mc->max_cpus to GUEST_MAX_VCPUS in xen_arm_init(), Volodymyr Babchuk, 2023/11/21
- [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Volodymyr Babchuk, 2023/11/21
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Paul Durrant, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Stefano Stabellini, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, David Woodhouse, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory,
Stefano Stabellini <=
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, David Woodhouse, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Stefano Stabellini, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Volodymyr Babchuk, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Volodymyr Babchuk, 2023/11/22
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Paul Durrant, 2023/11/23
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, David Woodhouse, 2023/11/23
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Volodymyr Babchuk, 2023/11/23
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, David Woodhouse, 2023/11/23
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, Volodymyr Babchuk, 2023/11/23
- Re: [PATCH v2 4/6] xen_pvdev: Do not assume Dom0 when creating a directory, David Woodhouse, 2023/11/23