qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/avocado: Replace assertEquals() for Python 3.12 compat


From: Thomas Huth
Subject: Re: [PATCH] tests/avocado: Replace assertEquals() for Python 3.12 compatibility
Date: Tue, 14 Nov 2023 15:21:01 +0100
User-agent: Mozilla Thunderbird

On 14/11/2023 15.10, Philippe Mathieu-Daudé wrote:
Hi Thomas,

On 14/11/23 14:43, Thomas Huth wrote:
assertEquals() has been removed in Python 3.12 and should be replaced by
assertEqual(). See: https://docs.python.org/3.12/whatsnew/3.12.html#id3

 From this list I see assertEquals() has been deprecated in 3.2, along
with assertRegexpMatches(). No warning for this single use?

tests/avocado/version.py:25:        self.assertRegexpMatches(res, r'^(\d+\.\d+\.\d)')

Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Thanks!

I still cannot run all avocado tests yet, so I didn't notice this problem
yet. But you're right, if I only run this test manually, it also fails.
Care to send a patch, or want me to include it in my patch?

Anyway, I'm seeing also failures here:

 tests/avocado/replay_kernel.py:ReplayKernelNormal.test_x86_64_pc: INTERRUPTED
 tests/avocado/reverse_debugging.py:ReverseDebugging_ppc64.test_ppc64_pseries: 
INTERRUPTED
 tests/avocado/reverse_debugging.py:ReverseDebugging_ppc64.test_ppc64_powernv: 
ERROR

Are these still working for you?
(IIRC at least the replay_kernel test was also failing for me
before I upgraded to Fedora 39, so it's likely not related to
the new Python version)

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]