qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 22/94] target/sparc: Move RDASR, STBAR, MEMBAR to decodetree


From: Peter Maydell
Subject: Re: [PULL 22/94] target/sparc: Move RDASR, STBAR, MEMBAR to decodetree
Date: Fri, 3 Nov 2023 19:07:30 +0000

On Thu, 26 Oct 2023 at 01:25, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>


> +static TCGv do_rdgsr(DisasContext *dc, TCGv dst)
> +{
> +    gen_trap_ifnofpu(dc);
> +    return cpu_gsr;
> +}
> +
> +TRANS(RDGSR, 64, do_rd_special, true, a->rd, do_rdgsr)

Hi; Coverity complains (CID 1523706) that we don't check
the return value from this call to gen_trap_ifnofpu(),
whereas we do check it on all but one other call.
Is this OK?

(Similarly in do_wrgsr(), CID 1523707.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]