[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tcg/tci: fix logic error when registering helpers via FFI
From: |
Peter Maydell |
Subject: |
Re: [PATCH] tcg/tci: fix logic error when registering helpers via FFI |
Date: |
Sun, 30 Oct 2022 10:27:54 +0000 |
On Sat, 29 Oct 2022 at 01:45, Icenowy Zheng <uwu@icenowy.me> wrote:
>
> 在 2022-10-29星期六的 06:28 +1100,Richard Henderson写道:
> > Oh my. I'm surprised any test cases at all worked.
> > Queued to tcg-next, with the declaration of j moved to the loop
> > itself:
> >
> > for (int j = 0; j < nargs; ++j)
>
> Ah I think this is a C99 feature. Is our C standard baseline high
> enough to use it?
Mmm, my instinctive reaction was that our style probably
doesn't permit that. But if you do
git grep 'for (int'
we already use it quite a bit...
-- PMM