[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 29/29] accel/tcg: Remove reset_icount argument from cpu_resto
From: |
Claudio Fontana |
Subject: |
Re: [PATCH 29/29] accel/tcg: Remove reset_icount argument from cpu_restore_state_from_tb |
Date: |
Tue, 25 Oct 2022 15:09:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 10/24/22 15:24, Richard Henderson wrote:
> The value passed is always true.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
> ---
> accel/tcg/translate-all.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
> index dd439b5e3c..9e7dd41795 100644
> --- a/accel/tcg/translate-all.c
> +++ b/accel/tcg/translate-all.c
> @@ -353,12 +353,11 @@ static int cpu_unwind_data_from_tb(TranslationBlock
> *tb, uintptr_t host_pc,
> }
>
> /*
> - * The cpu state corresponding to 'host_pc' is restored.
> - * When reset_icount is true, current TB will be interrupted and
> - * icount should be recalculated.
> + * The cpu state corresponding to 'host_pc' is restored in
> + * preparation for exiting the TB.
> */
> static void cpu_restore_state_from_tb(CPUState *cpu, TranslationBlock *tb,
> - uintptr_t host_pc, bool reset_icount)
> + uintptr_t host_pc)
> {
> uint64_t data[TARGET_INSN_START_WORDS];
> #ifdef CONFIG_PROFILER
> @@ -371,7 +370,7 @@ static void cpu_restore_state_from_tb(CPUState *cpu,
> TranslationBlock *tb,
> return;
> }
>
> - if (reset_icount && (tb_cflags(tb) & CF_USE_ICOUNT)) {
> + if (tb_cflags(tb) & CF_USE_ICOUNT) {
> assert(icount_enabled());
> /*
> * Reset the cycle counter to the start of the block and
> @@ -404,7 +403,7 @@ bool cpu_restore_state(CPUState *cpu, uintptr_t host_pc)
> if (in_code_gen_buffer((const void *)(host_pc - tcg_splitwx_diff))) {
> TranslationBlock *tb = tcg_tb_lookup(host_pc);
> if (tb) {
> - cpu_restore_state_from_tb(cpu, tb, host_pc, true);
> + cpu_restore_state_from_tb(cpu, tb, host_pc);
> return true;
> }
> }
> @@ -1715,7 +1714,7 @@ tb_invalidate_phys_page_range__locked(struct
> page_collection *pages,
> * restore the CPU state.
> */
> current_tb_modified = true;
> - cpu_restore_state_from_tb(cpu, current_tb, retaddr, true);
> + cpu_restore_state_from_tb(cpu, current_tb, retaddr);
> cpu_get_tb_cpu_state(env, ¤t_pc, ¤t_cs_base,
> ¤t_flags);
> }
> @@ -1874,7 +1873,7 @@ static bool tb_invalidate_phys_page(tb_page_addr_t
> addr, uintptr_t pc)
> restore the CPU state */
>
> current_tb_modified = 1;
> - cpu_restore_state_from_tb(cpu, current_tb, pc, true);
> + cpu_restore_state_from_tb(cpu, current_tb, pc);
> cpu_get_tb_cpu_state(env, ¤t_pc, ¤t_cs_base,
> ¤t_flags);
> }
> @@ -1904,7 +1903,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t
> retaddr)
> tb = tcg_tb_lookup(retaddr);
> if (tb) {
> /* We can use retranslation to find the PC. */
> - cpu_restore_state_from_tb(cpu, tb, retaddr, true);
> + cpu_restore_state_from_tb(cpu, tb, retaddr);
> tb_phys_invalidate(tb, -1);
> } else {
> /* The exception probably happened in a helper. The CPU state should
> @@ -1940,7 +1939,7 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr)
> cpu_abort(cpu, "cpu_io_recompile: could not find TB for pc=%p",
> (void *)retaddr);
> }
> - cpu_restore_state_from_tb(cpu, tb, retaddr, true);
> + cpu_restore_state_from_tb(cpu, tb, retaddr);
>
> /*
> * Some guests must re-execute the branch when re-executing a delay
- Re: [PATCH 19/29] target/sh4: Convert to tcg_ops restore_state_to_opc, (continued)
- [PATCH 26/29] target/openrisc: Always exit after mtspr npc, Richard Henderson, 2022/10/24
- [PATCH 25/29] target/i386: Use cpu_unwind_state_data for tpr access, Richard Henderson, 2022/10/24
- [PATCH 27/29] target/openrisc: Use cpu_unwind_state_data for mfspr, Richard Henderson, 2022/10/24
- [PATCH 28/29] accel/tcg: Remove will_exit argument from cpu_restore_state, Richard Henderson, 2022/10/24
- [PATCH 24/29] accel/tcg: Introduce cpu_unwind_state_data, Richard Henderson, 2022/10/24
- [PATCH 29/29] accel/tcg: Remove reset_icount argument from cpu_restore_state_from_tb, Richard Henderson, 2022/10/24
- Re: [PATCH 29/29] accel/tcg: Remove reset_icount argument from cpu_restore_state_from_tb,
Claudio Fontana <=