Re: [PATCH v4 01/11] reset: allow registering handlers that aren't called by snapshot loading

[Peter Maydell]

On Tue, 25 Oct 2022 at 13:33, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
>
> On Tue, Oct 25, 2022 at 2:26 PM Peter Maydell <peter.maydell@linaro.org> 
> wrote:
> >
> > On Tue, 25 Oct 2022 at 13:09, Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > >
> > > Hi Markus,
> > >
> > > On Tue, Oct 25, 2022 at 08:11:51AM +0200, Markus Armbruster wrote:
> > > > > diff --git a/qapi/run-state.json b/qapi/run-state.json
> > > > > index 49989d30e6..e44c0de914 100644
> > > > > --- a/qapi/run-state.json
> > > > > +++ b/qapi/run-state.json
> > > > > @@ -86,12 +86,15 @@
> > > > >  #                   ignores --no-reboot. This is useful for 
> > > > > sanitizing
> > > > >  #                   hypercalls on s390 that are used during 
> > > > > kexec/kdump/boot
> > > > >  #
> > > > > +# @snapshot-load: A snapshot is being loaded by the record & replay
> > > > > +#                 subsystem; internal value (since 7.2)
> > > > > +#
> > > >
> > > > If "internal value" was an established way to mark parts that aren't
> > > > visible externally, this would do.  Since it isn't, it's too terse.
> > > > Suggest something like "This value is used only within QEMU.  It doesn't
> > > > occur in QMP."
> > >
> > > Thanks for the precise text. I can do that for a v5, or, Peter - do you
> > > want to just fold that in upon committing these patches?
> >
> > If there's no other issues with the series I'll just fold that change in.
>
> Great, okay. Last time when we found this original snapshot reset
> issue, it surfaced because you put this somewhere that the CI ran on.

No, I was just running "make check-avocado" locally.

thanks
-- PMM