[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v14 07/17] net: socket: Don't ignore EINVAL on netdev socket conn
From: |
Laurent Vivier |
Subject: |
[PATCH v14 07/17] net: socket: Don't ignore EINVAL on netdev socket connection |
Date: |
Fri, 21 Oct 2022 11:09:12 +0200 |
From: Stefano Brivio <sbrivio@redhat.com>
Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
net/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index ade1ecf38b87..4944bb70d580 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");
--
2.37.3
- [PATCH v14 00/17] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/10/21
- [PATCH v14 02/17] net: remove the @errp argument of net_client_inits(), Laurent Vivier, 2022/10/21
- [PATCH v14 08/17] net: stream: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/10/21
- [PATCH v14 09/17] net: stream: add unix socket, Laurent Vivier, 2022/10/21
- [PATCH v14 01/17] net: introduce convert_host_port(), Laurent Vivier, 2022/10/21
- [PATCH v14 13/17] qemu-sockets: move and rename SocketAddress_to_str(), Laurent Vivier, 2022/10/21
- [PATCH v14 07/17] net: socket: Don't ignore EINVAL on netdev socket connection,
Laurent Vivier <=
- [PATCH v14 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/10/21
- [PATCH v14 15/17] net: stream: move to QIO to enable additional parameters, Laurent Vivier, 2022/10/21
[PATCH v14 17/17] net: stream: add QAPI events to report connection state, Laurent Vivier, 2022/10/21
[PATCH v14 10/17] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/10/21