Re: [RESEND PATCH] hw/mem/nvdimm: fix error message for 'unarmed' flag

[Pankaj Gupta]

> In the ACPI specification [1], the 'unarmed' bit is set when a device
> cannot accept a persistent write. This means that when a memdev is
> read-only, the 'unarmed' flag must be turned on. The logic is correct,
> just changing the error message.
>
> [1] ACPI NFIT NVDIMM Region Mapping Structure "NVDIMM State Flags" Bit 3
>
> Signed-off-by: Julia Suvorova <jusual@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  hw/mem/nvdimm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index 7c7d777781..bfb76818c1 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -149,7 +149,7 @@ static void nvdimm_prepare_memory_region(NVDIMMDevice 
> *nvdimm, Error **errp)
>      if (!nvdimm->unarmed && memory_region_is_rom(mr)) {
>          HostMemoryBackend *hostmem = dimm->hostmem;
>
> -        error_setg(errp, "'unarmed' property must be off since memdev %s "
> +        error_setg(errp, "'unarmed' property must be on since memdev %s "
>                     "is read-only",
>                     object_get_canonical_path_component(OBJECT(hostmem)));
>          return;

With the suggested minor change.

Reviewed-by: Pankaj Gupta <pankaj.gupta@amd.com>