[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/24] accel/tcg: Remove duplicate store to tb->page_addr[]
From: |
Richard Henderson |
Subject: |
[PATCH 08/24] accel/tcg: Remove duplicate store to tb->page_addr[] |
Date: |
Wed, 5 Oct 2022 20:10:57 -0700 |
When we added the fast path, we initialized page_addr[] early.
These stores in and around tb_page_add() are redundant; remove them.
Fixes: 50627f1b7b1 ("accel/tcg: Add fast path for translator_ld*")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/tb-maint.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 9af5cb49e0..7f4e1e1299 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -405,7 +405,6 @@ static inline void tb_page_add(PageDesc *p,
TranslationBlock *tb,
assert_page_locked(p);
- tb->page_addr[n] = page_addr;
tb->page_next[n] = p->first_tb;
#ifndef CONFIG_USER_ONLY
page_already_protected = p->first_tb != (uintptr_t)NULL;
@@ -461,8 +460,6 @@ TranslationBlock *tb_link_page(TranslationBlock *tb,
tb_page_addr_t phys_pc,
tb_page_add(p, tb, 0, phys_pc);
if (p2) {
tb_page_add(p2, tb, 1, phys_page2);
- } else {
- tb->page_addr[1] = -1;
}
/* add in the hash table */
--
2.34.1
- Re: [PATCH 01/24] util: Add interval-tree.c, (continued)
- [PATCH 03/24] accel/tcg: Remove disabled debug in translate-all.c, Richard Henderson, 2022/10/05
- [PATCH 04/24] accel/tcg: Split out PageDesc to internal.h, Richard Henderson, 2022/10/05
- [PATCH 06/24] accel/tcg: Move assert_no_pages_locked to internal.h, Richard Henderson, 2022/10/05
- [PATCH 07/24] accel/tcg: Drop cpu_get_tb_cpu_state from TARGET_HAS_PRECISE_SMC, Richard Henderson, 2022/10/05
- [PATCH 08/24] accel/tcg: Remove duplicate store to tb->page_addr[],
Richard Henderson <=
- [PATCH 05/24] accel/tcg: Split out tb-maint.c, Richard Henderson, 2022/10/05
- [PATCH 09/24] accel/tcg: Introduce tb_{set_}page_addr{0,1}, Richard Henderson, 2022/10/05
- [PATCH 10/24] accel/tcg: Rename tb_invalidate_phys_page, Richard Henderson, 2022/10/05
- [PATCH 11/24] accel/tcg: Rename tb_invalidate_phys_page_range and drop end parameter, Richard Henderson, 2022/10/05
- [PATCH 12/24] accel/tcg: Unify declarations of tb_invalidate_phys_range, Richard Henderson, 2022/10/05