[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] plugins: add [pre|post]fork helpers to linux-user [!TEST
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [RFC PATCH] plugins: add [pre|post]fork helpers to linux-user [!TESTED] |
|
Date: |
Tue, 4 Oct 2022 12:39:24 +0100 |
|
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Tue, Oct 04, 2022 at 12:33:30PM +0100, Alex Bennée wrote:
> Special care needs to be taken in ensuring locks are in a consistent
> state across fork events. Add helpers so the plugin system can ensure
> that.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Fixes: https://gitlab.com/qemu-project/qemu/-/issues/358
> ---
> include/qemu/plugin.h | 24 ++++++++++++++++++++++++
> linux-user/main.c | 2 ++
> plugins/core.c | 20 ++++++++++++++++++++
> 3 files changed, 46 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
I confirm it fixes the plugin hangs from #358.
Much much much less frequently, I can still hit the g_slice hangs
described in
https://gitlab.com/qemu-project/qemu/-/issues/285
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|