[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 13/15] gdbstub: move breakpoint logic to accel ops
From: |
Mads Ynddal |
Subject: |
Re: [PATCH v3 13/15] gdbstub: move breakpoint logic to accel ops |
Date: |
Tue, 4 Oct 2022 12:25:32 +0200 |
> As HW virtualization requires specific support to handle breakpoints
> lets push out special casing out of the core gdbstub code and into
> AccelOpsClass. This will make it easier to add other accelerator
> support and reduces some of the stub shenanigans.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Mads Ynddal <mads@ynddal.dk>
> ---
> accel/kvm/kvm-cpus.h | 3 +
> gdbstub/internals.h | 16 +++++
> include/sysemu/accel-ops.h | 6 ++
> include/sysemu/cpus.h | 3 +
> include/sysemu/kvm.h | 5 --
> accel/kvm/kvm-accel-ops.c | 8 +++
> accel/kvm/kvm-all.c | 24 +------
> accel/stubs/kvm-stub.c | 16 -----
> accel/tcg/tcg-accel-ops.c | 92 +++++++++++++++++++++++++++
> gdbstub/gdbstub.c | 127 +++----------------------------------
> gdbstub/softmmu.c | 42 ++++++++++++
> gdbstub/user.c | 62 ++++++++++++++++++
> softmmu/cpus.c | 7 ++
> gdbstub/meson.build | 8 +++
> 14 files changed, 259 insertions(+), 160 deletions(-)
Reviewed-by: Mads Ynddal <mads@ynddal.dk>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 13/15] gdbstub: move breakpoint logic to accel ops,
Mads Ynddal <=