[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docs: Correct the default thread-pool-size
From: |
Vivek Goyal |
Subject: |
Re: [PATCH] docs: Correct the default thread-pool-size |
Date: |
Thu, 14 Apr 2022 08:19:17 -0400 |
On Wed, Apr 13, 2022 at 12:20:54PM +0800, Liu Yiding wrote:
> Refer to 26ec190964 virtiofsd: Do not use a thread pool by default
>
> Signed-off-by: Liu Yiding <liuyd.fnst@fujitsu.com>
Looks good. Our default used to be --thread-pool-size=64. But we changed
it to using no thread pool because on lower end of workloads it performed
better. When multiple threads are doing parallel I/O then, thread pool
helps. So people who want to do lots of parallel I/O should manually
enable thread pool.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> ---
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
> index 0c0560203c..33fed08c6f 100644
> --- a/docs/tools/virtiofsd.rst
> +++ b/docs/tools/virtiofsd.rst
> @@ -127,7 +127,7 @@ Options
> .. option:: --thread-pool-size=NUM
>
> Restrict the number of worker threads per request queue to NUM. The
> default
> - is 64.
> + is 0.
>
> .. option:: --cache=none|auto|always
>
> --
> 2.31.1
>
>
>
>