[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL for-6.1 10/12] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_wri
From: |
Richard Henderson |
Subject: |
[PULL for-6.1 10/12] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write |
Date: |
Mon, 26 Jul 2021 11:47:27 -1000 |
>From clang-13:
hw/pci-host/pnv_phb4.c:375:18: error: variable 'v' set but not used \
[-Werror,-Wunused-but-set-variable]
It's pretty clear that we meant to write back 'v' after
all that computation and not 'val'.
Acked-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/pci-host/pnv_phb4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 54f57c660a..5c375a9f28 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -392,7 +392,7 @@ static void pnv_phb4_ioda_write(PnvPHB4 *phb, uint64_t val)
v &= 0xffffffffffff0000ull;
v |= 0x000000000000cfffull & val;
}
- *tptr = val;
+ *tptr = v;
break;
}
case IODA3_TBL_MBT:
--
2.25.1
- [PULL for-6.1 00/12] tcg and misc patch queue, Richard Henderson, 2021/07/26
- [PULL for-6.1 02/12] accel/tcg: Remove unnecessary check on icount_extra in cpu_loop_exec_tb(), Richard Henderson, 2021/07/26
- [PULL for-6.1 01/12] accel/tcg: Don't use CF_COUNT_MASK as the max value of icount_decr.u16.low, Richard Henderson, 2021/07/26
- [PULL for-6.1 03/12] bitops.h: revert db1ffc32dd ("qemu/bitops.h: add bitrev8 implementation"), Richard Henderson, 2021/07/26
- [PULL for-6.1 04/12] nbd/server: Mark variable unused in nbd_negotiate_meta_queries, Richard Henderson, 2021/07/26
- [PULL for-6.1 05/12] accel/tcg: Remove unused variable in cpu_exec, Richard Henderson, 2021/07/26
- [PULL for-6.1 06/12] util/selfmap: Discard mapping on error, Richard Henderson, 2021/07/26
- [PULL for-6.1 07/12] net/checksum: Remove unused variable in net_checksum_add_iov, Richard Henderson, 2021/07/26
- [PULL for-6.1 08/12] hw/audio/adlib: Remove unused variable in adlib_callback, Richard Henderson, 2021/07/26
- [PULL for-6.1 09/12] hw/ppc/spapr_events: Remove unused variable from check_exception, Richard Henderson, 2021/07/26
- [PULL for-6.1 10/12] hw/pci-hist/pnv_phb4: Fix typo in pnv_phb4_ioda_write,
Richard Henderson <=
- [PULL for-6.1 11/12] linux-user/syscall: Remove unused variable from execve, Richard Henderson, 2021/07/26
- [PULL for-6.1 12/12] tests/unit: Remove unused variable from test_io, Richard Henderson, 2021/07/26
- Re: [PULL for-6.1 00/12] tcg and misc patch queue, Peter Maydell, 2021/07/27