[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbu
From: |
minyard |
Subject: |
[Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom |
Date: |
Thu, 28 Feb 2019 12:17:09 -0600 |
From: Corey Minyard <address@hidden>
Reset the contents to init data and reset the offset on a machine
reset.
Signed-off-by: Corey Minyard <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/i2c/smbus_eeprom.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
index 5b10c31ae7..0ba5763fc2 100644
--- a/hw/i2c/smbus_eeprom.c
+++ b/hw/i2c/smbus_eeprom.c
@@ -108,7 +108,17 @@ static const VMStateDescription vmstate_smbus_eeprom = {
}
};
-static void smbus_eeprom_realize(DeviceState *dev, Error **errp)
+/*
+ * Reset the EEPROM contents to the initial state on a reset. This
+ * isn't really how an EEPROM works, of course, but the general
+ * principle of QEMU is to restore function on reset to what it would
+ * be if QEMU was stopped and started.
+ *
+ * The proper thing to do would be to have a backing blockdev to hold
+ * the contents and restore that on startup, and not do this on reset.
+ * But until that time, act as if we had been stopped and restarted.
+ */
+static void smbus_eeprom_reset(DeviceState *dev)
{
SMBusEEPROMDevice *eeprom = SMBUS_EEPROM(dev);
@@ -116,6 +126,11 @@ static void smbus_eeprom_realize(DeviceState *dev, Error
**errp)
eeprom->offset = 0;
}
+static void smbus_eeprom_realize(DeviceState *dev, Error **errp)
+{
+ smbus_eeprom_reset(dev);
+}
+
static Property smbus_eeprom_properties[] = {
DEFINE_PROP_PTR("data", SMBusEEPROMDevice, init_data),
DEFINE_PROP_END_OF_LIST(),
@@ -127,6 +142,7 @@ static void smbus_eeprom_class_initfn(ObjectClass *klass,
void *data)
SMBusDeviceClass *sc = SMBUS_DEVICE_CLASS(klass);
dc->realize = smbus_eeprom_realize;
+ dc->reset = smbus_eeprom_reset;
sc->receive_byte = eeprom_receive_byte;
sc->write_data = eeprom_write_data;
dc->props = smbus_eeprom_properties;
--
2.17.1
- [Qemu-devel] [PULL 00/19] Fix/add vmstate handling in some I2C code, minyard, 2019/02/28
- [Qemu-devel] [PULL 02/19] i2c: have I2C receive operation return uint8_t, minyard, 2019/02/28
- [Qemu-devel] [PULL 03/19] arm:i2c: Don't mask return from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 06/19] i2c:smbus: Simplify write operation, minyard, 2019/02/28
- [Qemu-devel] [PULL 15/19] i2c:smbus_eeprom: Add normal type name and cast to smbus_eeprom.c, minyard, 2019/02/28
- [Qemu-devel] [PULL 18/19] i2c:smbus_eeprom: Add a reset function to smbus_eeprom,
minyard <=
- [Qemu-devel] [PULL 01/19] i2c: Split smbus into parts, minyard, 2019/02/28
- [Qemu-devel] [PULL 17/19] i2c:smbus_eeprom: Add vmstate handling to the smbus eeprom, minyard, 2019/02/28
- [Qemu-devel] [PULL 04/19] i2c: Don't check return value from i2c_recv(), minyard, 2019/02/28
- [Qemu-devel] [PULL 11/19] i2c:pm_smbus: Fix pm_smbus handling of I2C block read, minyard, 2019/02/28
- [Qemu-devel] [PULL 10/19] boards.h: Ignore migration for SMBus devices on older machines, minyard, 2019/02/28
- [Qemu-devel] [PULL 09/19] i2c:smbus: Make white space in switch statements consistent, minyard, 2019/02/28
- [Qemu-devel] [PULL 16/19] i2c:smbus_eeprom: Add a size constant for the smbus_eeprom size, minyard, 2019/02/28
- [Qemu-devel] [PULL 05/19] i2c:smbus: Correct the working of quick commands, minyard, 2019/02/28
- [Qemu-devel] [PULL 07/19] i2c:smbus: Simplify read handling, minyard, 2019/02/28
- [Qemu-devel] [PULL 12/19] migration: Add a VMSTATE_BOOL_TEST() macro, minyard, 2019/02/28