Re: [Qemu-devel] [PATCH 17/51] i386: express dependencies with Kconfig

[Markus Armbruster]

Paolo Bonzini <address@hidden> writes:

> On 25/02/19 09:44, Stefano Garzarella wrote:
>>>  config I440FX
>>>      bool
>>> +    select PC_PCI
>>> +    select PC_ACPI
>>> +    select ACPI_SMBUS
>>> +    select PCI_PIIX
>>> +    select FDC
>> Should we move "select FDC" under "config PC"?
>> 
>> I'm not able to build the Q35 machine without enable FDC, since some fdc
>> functions are used in hw/i386/pc.c (eg. isa_fdc_get_drive_type())
>
> Yes, that's a good idea.  I mistakenly thought that Q35 could be built
> without FDC.

Could we add stubs to make it buildable that way?