Re: [Qemu-devel] [PATCH v2 3/4] block/dirty-bitmaps: add block_dirty_bitmap_check function

[Vladimir Sementsov-Ogievskiy]

25.02.2019 18:07, Eric Blake wrote:
> On 2/25/19 8:59 AM, Vladimir Sementsov-Ogievskiy wrote:
> 
>>
>> And one more important question: we now creating new qapi bitmap status, 
>> consisting of several bool fields.
>> Shouldn't we instead implement it as an array of flags?
> 
> Parsing:
> 
> { "busy": false, "persistent": false, "recording": true }
> 
> is easier than parsing:
> 
> { "flags": [ "recording" ] }
> 
> (and knowing that unlisted flags "busy", "persistent", and
> "inconsistent" are false), or:
> 
> { "flags": [ { "busy": false }, { "persistent": false }, { "recording":
> true } ] }
> 
> So without more reason why an array of flags would be needed, I don't
> see the point for it.
> 

Ok. The only reason I see is upcoming appearance of flags in implementation. 
But it seems not enough reason.

-- 
Best regards,
Vladimir