Re: [Qemu-devel] [PATCH v3 12/13] contrib: add vhost-user-input

[Marc-André Lureau]

Hi

On Thu, Feb 21, 2019 at 10:53 AM Gerd Hoffmann <address@hidden> wrote:
>
> On Fri, Feb 08, 2019 at 12:23:56PM +0100, Marc-André Lureau wrote:
> > Add a vhost-user input backend example, based on virtio-input-host
> > device. It takes an evdev path as argument, and can be associated with
> > a vhost-user-input device via a UNIX socket:
> >
> > $ vhost-user-input -p /dev/input/eventX -s /tmp/vui.sock
> >
> > $ qemu ... -chardev socket,id=vuic,path=/tmp/vui.sock
> >   -device vhost-user-input-pci,chardev=vuic
>
> > +static int unix_sock_new(char *path)
> > +{
>
> Move to the library?  This looks like something other backends will need
> too.
>

Eventually. I am not sure libvhost-user is the right place though.

We could eventually link with a util/ object.

That could be done in a seperate patch, since there are already
several similar functions in qemu source tree.


Thanks


-- 
Marc-André Lureau