Re: [Qemu-devel] [PATCH] hw/display: Add basic ATI VGA emulation

[BALATON Zoltan]

On Thu, 21 Feb 2019, BALATON Zoltan wrote:
> On Tue, 19 Feb 2019, Peter Maydell wrote:
> > On Tue, 12 Feb 2019 at 23:59, BALATON Zoltan <address@hidden> wrote:
> > > On Tue, 12 Feb 2019, Philippe Mathieu-Daudé wrote:
> > > > I'd have use a pair of extract32/deposit32 but this is probably easier

By the way, should these lines in include/qemu/bitops.h have 1ULL instead of 
1UL?

22 #define BIT(nr)                 (1UL << (nr))
23 #define BIT_MASK(nr)            (1UL << ((nr) % BITS_PER_LONG))

Regards,
BALATON Zoltan