[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotplug
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotpluggable |
Date: |
Wed, 20 Feb 2019 02:13:29 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 2/20/19 1:51 AM, Wei Yang wrote:
> Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM,
> which is hotpluggable. This means it is not necessary to check this
> property again.
>
> This patch removes this check.
>
> Signed-off-by: Wei Yang <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v2:
> * remove unused dc
> ---
> hw/acpi/memory_hotplug.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> index 8c7c1013f3..cb5284d36f 100644
> --- a/hw/acpi/memory_hotplug.c
> +++ b/hw/acpi/memory_hotplug.c
> @@ -264,11 +264,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev,
> MemHotplugState *mem_st,
> DeviceState *dev, Error **errp)
> {
> MemStatus *mdev;
> - DeviceClass *dc = DEVICE_GET_CLASS(dev);
> -
> - if (!dc->hotpluggable) {
> - return;
> - }
>
> mdev = acpi_memory_slot_status(mem_st, dev, errp);
> if (!mdev) {
>
- [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup, Wei Yang, 2019/02/19
- [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotpluggable, Wei Yang, 2019/02/19
- Re: [Qemu-devel] [PATCH v2 1/3] pc-dimm: remove check on pc-dimm hotpluggable,
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH v2 2/3] mem/nvdimm: remove nvdimm_realize, Wei Yang, 2019/02/19
- [Qemu-devel] [PATCH v2 3/3] pc-dimm: revert "introduce realize callback", Wei Yang, 2019/02/19
- Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup, Xiao Guangrong, 2019/02/21
- Re: [Qemu-devel] [PATCH v2 0/3] PCDIMM cleanup, Igor Mammedov, 2019/02/21