Re: [Qemu-devel] [PATCH v3 0/5] Add ignore-external migration capability

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v3 0/5] Add ignore-external migration capability
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5f9e90967e migration: Add capabilities validation
fad48088a8 tests/migration-test: Add a test for ignore-shared capability
68347ad2eb migration: Add an ability to ignore shared RAM blocks
e3d2fd0298 migration: Introduce ignore-shared capability
73d9e23937 exec: Change RAMBlockIterFunc definition

=== OUTPUT BEGIN ===
1/5 Checking commit 73d9e23937e9 (exec: Change RAMBlockIterFunc definition)
2/5 Checking commit e3d2fd0298a4 (migration: Introduce ignore-shared capability)
3/5 Checking commit 68347ad2eb24 (migration: Add an ability to ignore shared 
RAM blocks)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#146: FILE: migration/ram.c:169:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block)            \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (ramblock_is_ignored(block)) {} else

ERROR: trailing statements should be on next line
#148: FILE: migration/ram.c:171:
+        if (ramblock_is_ignored(block)) {} else

total: 2 errors, 0 warnings, 386 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit fad48088a805 (tests/migration-test: Add a test for 
ignore-shared capability)
5/5 Checking commit 5f9e90967e69 (migration: Add capabilities validation)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden