[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/15] s390x/tcg: Implement XxC and checks fo
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 12/15] s390x/tcg: Implement XxC and checks for most FP instructions |
Date: |
Wed, 13 Feb 2019 11:31:49 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/13/19 6:33 AM, David Hildenbrand wrote:
> With the floating-point extension facility
> - CONVERT FROM LOGICAL
> - CONVERT TO LOGICAL
> - CONVERT TO FIXED
> - CONVERT FROM FIXED
> - LOAD FP INTEGER
> have both, a rounding mode specification and the inexact-exception control
> (XxC). Other instructions will be handled separatly.
>
> Check for valid rounding modes and forward also the XxC (via m4). To avoid
> a lot of boilerplate code and changes to the helpers, combine both, the
> m3 and m4 field in a combined 32 bit TCG variable. Perform checks at
> a central place, taking in account if the m3 or m4 field was ignore
> before the floating-point extension facility was introduced.
>
> Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
> +static inline bool xxc_from_m34(uint32_t m34)
> +{
> + /* XxC is bit 1 of m4 */
> + return (extract32(m34, 4, 4) & 0x4) != 0;
Better as extract32(m32, 6, 1);
r~
- [Qemu-devel] [PATCH v2 02/15] s390x/tcg: Fix rounding from float128 to uint64_t/uin32_t, (continued)
- [Qemu-devel] [PATCH v2 02/15] s390x/tcg: Fix rounding from float128 to uint64_t/uin32_t, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 05/15] s390x/tcg: Hide IEEE underflows in some scenarios, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 04/15] s390x/tcg: Fix parts of IEEE exception handling, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 06/15] s390x/tcg: Refactor SET FPC AND SIGNAL handling, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 07/15] s390x/tcg: Fix simulated-IEEE exceptions, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 08/15] s390x/tcg: Handle SET FPC AND LOAD FPC 3-bit BFP rounding modes, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 09/15] s390x/tcg: Check for exceptions in SET BFP ROUNDING MODE, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 10/15] s390x/tcg: Refactor saving/restoring the bfp rounding mode, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 15/15] s390x: Add floating-point extension facility to "qemu" cpu model, David Hildenbrand, 2019/02/13
- [Qemu-devel] [PATCH v2 12/15] s390x/tcg: Implement XxC and checks for most FP instructions, David Hildenbrand, 2019/02/13
- Re: [Qemu-devel] [PATCH v2 12/15] s390x/tcg: Implement XxC and checks for most FP instructions,
Richard Henderson <=
[Qemu-devel] [PATCH v2 11/15] s390x/tcg: Prepare for IEEE-inexact-exception control (XxC), David Hildenbrand, 2019/02/13
[Qemu-devel] [PATCH v2 13/15] s390x/tcg: Implement rounding mode and XxC for LOAD ROUNDED, David Hildenbrand, 2019/02/13
[Qemu-devel] [PATCH v2 14/15] s390x/tcg: Handle all rounding modes overwritten by BFP instructions, David Hildenbrand, 2019/02/13