Re: [Qemu-devel] [PATCH 1/5] tests/tcg: target/mips: Remove an unnecessary file

[Aleksandar Markovic]

> From: Eric Blake <address@hidden>
> Sent: Tuesday, February 12, 2019 9:04 PM
> To: Aleksandar Markovic; address@hidden
> Cc: Aleksandar Rikalo; address@hidden; Aleksandar Markovic; address@hidden
> Subject: Re: [Qemu-devel] [PATCH 1/5] tests/tcg: target/mips: Remove an 
> unnecessary file
> 
> On 2/12/19 1:53 PM, Aleksandar Markovic wrote:
> > From: Aleksandar Markovic <address@hidden>
> >
> > Remove a file that was added long time ago by mistake.
> 
> Might be worth mentioning commit d70080c4 (in 2012).

I am going to mention it in the next version of this series.

> 
> Is this the sort of file that is likely enough to be created during
> typical workflows that it should be listed in the project's .gitignore
> for everyone?  Or is it particular enough to your environment that you
> could 'echo .directory >> .git/info/exclude' to ensure it doesn't happen
> again for your setup, without bothering other developers with your
> exclusion?
> 

It is particular enough, no need to update .gitingnore for everyone, IMHO.

> Either way, the cleanup itself makes sense.
> 
> Reviewed-by: Eric Blake <address@hidden>
> 
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org

Thanks,
Aleksandar