[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum |
Date: |
Sat, 9 Feb 2019 14:15:06 +0100 |
Hi
On Mon, Jan 7, 2019 at 10:46 AM Gerd Hoffmann <address@hidden> wrote:
>
> On Thu, Dec 20, 2018 at 08:46:13AM -0600, Eric Blake wrote:
> > On 12/20/18 8:15 AM, Marc-André Lureau wrote:
> > > Signed-off-by: Marc-André Lureau <address@hidden>
> > > ---
> > > qapi/ui.json | 24 ++++++++++++++++++++++++
> > > 1 file changed, 24 insertions(+)
> > >
> > > diff --git a/qapi/ui.json b/qapi/ui.json
> > > index 5ad13248d5..3f2f662dca 100644
> > > --- a/qapi/ui.json
> > > +++ b/qapi/ui.json
> > > @@ -1075,6 +1075,30 @@
> > > #
> > > # Display (user interface) type.
> > > #
> > > +# @default: The default user interface.
> >
> > Any more hints on how this default is determined? Is it a compile-time
> > decision, based on what libraries were linked in?
>
> Basically yes. A bit more complicated due to modules. gtk, sdl and
> cocoa are checked, in that order. And if none of them is available the
> vnc server is enabled.
Eric, should I cram this comment there?: "(gtk, sdl and
cocoa are checked, in that order. And if none of them is available the
vnc server is enabled)"
thanks
>
> > Does the work on adding
> > #if support to qapi make it introspectible what the default is?
>
> Due to modules it isn't a compile time constant. With a modular build
> and gtk being packaged as separate sub-rpm the default depends on
> whenever the sub-rpm is installed or not.
>
> So I guess the answer is "no".
>
> cheers,
> Gerd
>
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH v2 10/12] qapi: document DisplayType enum,
Marc-André Lureau <=