Re: [Qemu-devel] [Bug 1815024] [NEW] SIGILL on instruction "stck" under qemu-s390x in user mode

[Thomas Huth]

On 2019-02-07 14:00, Giovanni Mascellani wrote:
> Hi,
> 
> Il 07/02/19 13:15, Richard Henderson ha scritto:
>> See also
>>
>>   https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg06734.html
>>
>> which I never followed up on the review changes requested.
> 
> I can confirm that both patches (Thomas' and Richard's) work for me.
> Although they produce rather different results:
> 
>  Thomas' patch:   around 6346926678828662276
>  Richard's patch: around 9048173079139739571
> 
> They also appear to grow at different speeds, if I am not mistaken. I
> have no idea of what is correct, because I do not know s390x.

Both are wrong. I missed to add the TOD_UNIX_EPOCH offset, and Richard
missed to use the time2tod() conversion.

Anyway, I yield to Richard's patches since he posted his patches first
(unless he does not have any spare time to work on it at all, then I
could have another look).

 Thomas

signature.asc
Description: OpenPGP digital signature