Re: [Qemu-devel] [PULLv3 00/32] More work towards libslirp

[Daniel P . Berrangé]

On Thu, Feb 07, 2019 at 11:46:23AM +0000, Peter Maydell wrote:
> On Tue, 5 Feb 2019 at 18:28, Samuel Thibault
> <address@hidden> wrote:
> >
> > The following changes since commit 01a9a51ffaf4699827ea6425cb2b834a356e159d:
> >
> >   Merge remote-tracking branch 
> > 'remotes/kraxel/tags/ui-20190205-pull-request' into staging (2019-02-05 
> > 14:01:29 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://people.debian.org/~sthibault/qemu.git tags/samuel-thibault
> >
> > for you to fetch changes up to 1e924479dce65a26a7432bf5920f89c1bf957d74:
> >
> >   slirp: API is extern C (2019-02-05 20:27:27 +0200)
> >
> > ----------------------------------------------------------------
> > More work towards libslirp
> >
> 
> Format string issues for the Windows build:
> 
> /home/petmay01/qemu-for-merges/slirp/slirp.c: In function
> 'slirp_send_packet_all':
> /home/petmay01/qemu-for-merges/slirp/slirp.c:1116:20: error: unknown
> conversion type character 'z' in format [-Werror=format=]
>          g_critical("Failed to send packet, ret: %zd", ret);
>                     ^

Note that with any of the glib functions that take a format string,
you *must* use the glib format macros, not the system provided
format macros.  ie  G_*_FORMAT, not any of the PRI*  macros
from stdint.h.   This is because you can't assume that the glib
functions call through to the platform's own printf impl. See:

  https://developer.gnome.org/glib/stable/glib-Basic-Types.html

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|