Re: [Qemu-devel] [PATCH v1] softfloat: Implement float128_to_uint32

[David Hildenbrand]

On 06.02.19 16:12, Alex Bennée wrote:
> 
> David Hildenbrand <address@hidden> writes:
> 
>> Handling it just like float128_to_uint32_round_to_zero, that hopefully
>> is free of bugs :)
>>
>> Documentation basically copied from float128_to_uint64
> 
> Queued to fpu/next, thanks.
> 
> BTW to test:
> 
> tests/fp: add wrapping for f128_to_ui32
> 
> Needed to test: softfloat: add float128_is_{normal,denormal}

Thanks, was that supposed to be "softfloat: Implement float128_to_uint32" ?

> 
> Signed-off-by: Alex Bennée <address@hidden>
> 
> 2 files changed, 3 insertions(+), 1 deletion(-)
> tests/fp/fp-test.c  | 3 ++-
> tests/fp/wrap.inc.c | 1 +
> 
> modified   tests/fp/fp-test.c
> @@ -622,7 +622,8 @@ static void do_testfloat(int op, int rmode, bool exact)
>          test_ab_extF80_z_bool(true_ab_extF80M_z_bool, 
> subj_ab_extF80M_z_bool);
>          break;
>      case F128_TO_UI32:
> -        not_implemented();
> +        test_a_f128_z_ui32_rx(slow_f128M_to_ui32, qemu_f128M_to_ui32, rmode,
> +                              exact);
>          break;
>      case F128_TO_UI64:
>          test_a_f128_z_ui64_rx(slow_f128M_to_ui64, qemu_f128M_to_ui64, rmode,
> modified   tests/fp/wrap.inc.c
> @@ -367,6 +367,7 @@ WRAP_80_TO_INT_MINMAG(qemu_extF80M_to_i64_r_minMag,
>  WRAP_128_TO_INT(qemu_f128M_to_i32, float128_to_int32, int_fast32_t)
>  WRAP_128_TO_INT(qemu_f128M_to_i64, float128_to_int64, int_fast64_t)
> 
> +WRAP_128_TO_INT(qemu_f128M_to_ui32, float128_to_uint32, uint_fast32_t)
>  WRAP_128_TO_INT(qemu_f128M_to_ui64, float128_to_uint64, uint_fast64_t)
>  #undef WRAP_128_TO_INT
> 
> --
> Alex Bennée
> 


-- 

Thanks,

David / dhildenb