[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/10] hw/rdma: Warn when too many consecutive p
|
From: |
Yuval Shaia |
|
Subject: |
Re: [Qemu-devel] [PATCH 03/10] hw/rdma: Warn when too many consecutive poll CQ triggered on an empty CQ |
|
Date: |
Wed, 6 Feb 2019 17:02:27 +0200 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
> > @@ -60,6 +60,8 @@ static int pvrdma_post_cqe(PVRDMADev *dev, uint32_t
> > cq_handle,
> > return -EINVAL;
> > }
> > + atomic_dec(&cq->missing_cqe);
> > +
>
> We should set it to 0 here? (If we are counting cq-empty hits)
No, this counter just count the number of missing CQEs. It is increased on
every WQE we are posting and decreased on every CQE we receive. What is
remain is the missing CQEs.
>
> > ring = (PvrdmaRing *)cq->opaque;
> > /* Step #1: Put CQE on CQ ring */