[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] queue: fix QTAILQ_FOREACH_REVERSE_SAFE
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH] queue: fix QTAILQ_FOREACH_REVERSE_SAFE |
|
Date: |
Mon, 4 Feb 2019 11:09:12 -0500 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Mon, Feb 04, 2019 at 16:43:12 +0100, Paolo Bonzini wrote:
> The iteration was stopping as soon as prev_var was set to NULL, and
> therefore it skipped the first element. Fortunately, or unfortunately,
> we have only one use of QTAILQ_FOREACH_REVERSE_SAFE. Thus this only
> showed up as incorrect register preferences on the very first translation
> block that was compiled.
>
> Reported-by: Thomas Huth <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Emilio G. Cota <address@hidden>
E.