[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Segfaults in chardev due to races
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] Segfaults in chardev due to races |
|
Date: |
Sat, 22 Dec 2018 10:17:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 21/12/18 23:31, Max Reitz wrote:
> I suppose the issue is that QMP events are sent by one thread, and
> client disconnects are handled by a different one. So if a QMP event is
> sent while a client disconnects concurrently, races may occur; and the
> only protection against concurrent access appears to be the
> chr_write_lock, which I don't think is enough.
I think disconnection (tcp_chr_disconnect) has to take the
chr_write_lock too.
Paolo