Re: [Qemu-devel] [PATCH] i386: remove the 'INTEL_PT' CPUID bit from named CPU models

[Paolo Bonzini]

On 21/12/18 16:22, Philippe Mathieu-Daudé wrote:
> Hi Paolo,
> 
> On 12/21/18 7:30 AM, Paolo Bonzini wrote:
>> From: Robert Hoo <address@hidden>
>>
>> Processor tracing is not yet implemented for KVM and it will be an
>> opt in feature requiring a special module parameter.
>> Disable it, because it is wrong to enable it by default and
>> it is impossible that no one has ever used it.
>>
>> Cc: address@hidden
> 
> Does this patch misses Robert S-o-b?
> Signed-off-by: Robert Hoo <address@hidden>

No, the author is wrong, it should be me.  "git commit -c" apparently
copies the author from the original commit.

Paolo

>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>>  target/i386/cpu.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index dae46f0319..9c54c41e7a 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -2493,8 +2493,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>>              CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_CLWB |
>>              CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512DQ |
>>              CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512CD |
>> -            CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT |
>> -            CPUID_7_0_EBX_INTEL_PT,
>> +            CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT,
>>          .features[FEAT_7_0_ECX] =
>>              CPUID_7_0_ECX_PKU | CPUID_7_0_ECX_OSPKE |
>>              CPUID_7_0_ECX_AVX512VNNI,
>> @@ -2546,7 +2545,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>>              CPUID_7_0_EBX_HLE | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP |
>>              CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_ERMS | CPUID_7_0_EBX_INVPCID 
>> |
>>              CPUID_7_0_EBX_RTM | CPUID_7_0_EBX_RDSEED | CPUID_7_0_EBX_ADX |
>> -            CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_INTEL_PT,
>> +            CPUID_7_0_EBX_SMAP,
>>          .features[FEAT_7_0_ECX] =
>>              CPUID_7_0_ECX_VBMI | CPUID_7_0_ECX_UMIP | CPUID_7_0_ECX_PKU |
>>              CPUID_7_0_ECX_OSPKE | CPUID_7_0_ECX_VBMI2 | CPUID_7_0_ECX_GFNI |
>> @@ -2604,8 +2603,7 @@ static X86CPUDefinition builtin_x86_defs[] = {
>>              CPUID_7_0_EBX_SMAP | CPUID_7_0_EBX_CLWB |
>>              CPUID_7_0_EBX_AVX512F | CPUID_7_0_EBX_AVX512DQ |
>>              CPUID_7_0_EBX_AVX512BW | CPUID_7_0_EBX_AVX512CD |
>> -            CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT |
>> -            CPUID_7_0_EBX_INTEL_PT,
>> +            CPUID_7_0_EBX_AVX512VL | CPUID_7_0_EBX_CLFLUSHOPT,
>>          .features[FEAT_7_0_ECX] =
>>              CPUID_7_0_ECX_VBMI | CPUID_7_0_ECX_UMIP | CPUID_7_0_ECX_PKU |
>>              CPUID_7_0_ECX_OSPKE | CPUID_7_0_ECX_VBMI2 | CPUID_7_0_ECX_GFNI |
>>