[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words |
|
Date: |
Thu, 20 Dec 2018 10:05:44 -0200 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Dec 19, 2018 at 06:25:06PM +0100, Vitaly Kuznetsov wrote:
> Eduardo Habkost <address@hidden> writes:
>
> > On Mon, Dec 03, 2018 at 03:17:06PM +0100, Vitaly Kuznetsov wrote:
> >> Eduardo Habkost <address@hidden> writes:
> > [...]
> >> > But note that we might still be able to move the existing
> >> > "hyperv_*" features to feature_word_info[].feat_names. We just
> >> > need to keep the same semantics (e.g. enable
> >> > HV_HYPERCALL_AVAILABLE automatically when some features are set).
> >> >
> >> > Maybe we can make some of the feature properties read-only. This
> >> > way we can give them meaningful names for debugging and error
> >> > messages, even if we don't want to make them configurable
> >> > directly.
> >>
> >> I'd suggest (if there are no objections of course) we do this separately
> >> from this patch. [...]
> >
> > Agreed.
> >
>
> Paolo, Eduardo,
>
> in case there are no concerns here, could you please pick this patch up?
> Thanks!
Queued, thanks!
Can you please send the comment you wrote about feat_names as a
follow-up patch?
--
Eduardo