[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/7] bitmaps: remove x- prefix from QMP api |
Date: |
Wed, 19 Dec 2018 20:24:38 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/17/18 4:14 PM, John Snow wrote:
>
>
> On 12/14/18 6:15 PM, John Snow wrote:
>> Touch up a few last things and remove the x- prefix.
>>
>> V3:
>> - Reworked qmp_log to pretty-print the outgoing command, too [Vladimir]
>> - Modified test to log only bitmap information [Vladimir]
>> - Test disable/enable transaction toggle [Eric]
>>
>> Note that the filter I added is now unused, but I think we will want it
>> and it's small enough, so I'm going to check it in anyway. If you disagree,
>> I'll just drop the patch instead.
>>
>> --js
>>
>> John Snow (7):
>> blockdev: abort transactions in reverse order
>> blockdev: n-ary bitmap merge
>> block: remove 'x' prefix from experimental bitmap APIs
>> iotests.py: don't abort if IMGKEYSECRET is undefined
>> iotests: add filter_generated_node_ids
>> iotests: allow pretty-print for qmp_log
>> iotests: add iotest 236 for testing bitmap merge
>>
>> blockdev.c | 96 +++++++++-------
>> qapi/block-core.json | 56 +++++-----
>> qapi/transaction.json | 12 +-
>> tests/qemu-iotests/223 | 4 +-
>> tests/qemu-iotests/236 | 124 +++++++++++++++++++++
>> tests/qemu-iotests/236.out | 200 ++++++++++++++++++++++++++++++++++
>> tests/qemu-iotests/group | 1 +
>> tests/qemu-iotests/iotests.py | 22 +++-
>> 8 files changed, 436 insertions(+), 79 deletions(-)
>> create mode 100755 tests/qemu-iotests/236
>> create mode 100644 tests/qemu-iotests/236.out
>>
>
> Thanks, I'm staging patches 1-5 and I'll send the PR once we get to the
> bottom of patches 6 and 7, just to keep volume on the list down.
>
NACK.
Patch 2 is incomplete an additional bugfix is needed.
--js