[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command to proceed to the desired step |
Date: |
Wed, 19 Dec 2018 14:08:48 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Pavel Dovgalyuk <address@hidden> writes:
> This patch adds hmp/qmp commands replay_seek/replay-seek that proceed
> the execution to the specified step.
> The commands automatically loads nearest snapshot and replay the execution
> to find the desired step.
>
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
[...]
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 0bcb547..9989706 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -3179,6 +3179,22 @@
> { 'command': 'replay-delete-break' }
>
> ##
> +# @replay-seek:
> +#
> +# Automatically proceeds to the specified step when replaying
> +# the execution.
> +#
> +# @step: destination execution step
> +#
> +# Since: 4.0
> +#
> +# Example:
> +#
> +# -> { "execute": "replay-seek", "data": { "step": 220414 } }
> +##
> +{ 'command': 'replay-seek', 'data': { 'step': 'int' } }
> +
> +##
Your commit message explains the relation to snapshots. The QMP
documentation doesn't.
What happens when no snapshot preceding @step exists?
[...]
- [Qemu-devel] [PATCH v8 08/20] migration: introduce icount field for snapshots, (continued)
- [Qemu-devel] [PATCH v8 08/20] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 09/20] replay: provide and accessor for rr filename, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 10/20] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 11/20] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/12/18
- Re: [Qemu-devel] [PATCH v8 12/20] replay: implement replay-seek command to proceed to the desired step,
Markus Armbruster <=
- [Qemu-devel] [PATCH v8 13/20] replay: refine replay-time module, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 14/20] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 15/20] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 16/20] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 17/20] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 18/20] replay: add BH oneshot event for block layer, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 19/20] replay: init rtc after enabling the replay, Pavel Dovgalyuk, 2018/12/18
- [Qemu-devel] [PATCH v8 20/20] replay: document development rules, Pavel Dovgalyuk, 2018/12/18
- Re: [Qemu-devel] [PATCH v8 00/20] Fixing record/replay and adding reverse debugging, no-reply, 2018/12/24