[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when pic
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/5] keymap: consider modifier state when picking a mapping |
Date: |
Wed, 19 Dec 2018 11:17:12 +0000 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Dec 19, 2018 at 10:42:14AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > This is quite horrible though. I'm more inclined
> > > to revert this patch and find another way to fix the original problem
> > > which won't require the UI frontends to track modifier state.
> >
> > The UIs track modifier state anyway.
> >
> > I fact I have some WIP patches to add a generic keyboard state tracker,
> > so the UIs can use common code instead of having their own state
> > tracking code each. Also to make UI hotkeys configurable, consistent
> > across all UIs we have. Guess I should undust them, at least the state
> > tracking part of it.
> >
> > With that in place we can easily pass the full keyboard state to the
> > keymap code.
>
> Tried that:
> https://git.kraxel.org/cgit/qemu/log/?h=sirius/kbd-state
I've had a look & think that code makes sense & ought to be able to
solve this problem.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|