[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_po
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [QEMU-devel][PATCH v3] aio-posix: Fix concurrent aio_poll/set_fd_handler. |
|
Date: |
Tue, 18 Dec 2018 18:39:55 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 17/12/18 17:48, address@hidden wrote:
> Also, we do not call aio_epoll_update for deleted handlers as this has
> no impact whatsoever.
Why? epoll is used in level-triggered mode, so you do have to remove
the file descriptor...
> atomic_read(&ctx->poll_disable_cnt) + poll_disable_change);
>
> - aio_epoll_update(ctx, node, is_new);
> + if (new_node) {
> + aio_epoll_update(ctx, new_node, is_new);
> + }
> qemu_lockcnt_unlock(&ctx->list_lock);
> aio_notify(ctx);
... so I think this should be "if (node || new_node)"?
Paolo