[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 5/7] qga: update guest-suspend-ram and guest-suspend-
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PULL 5/7] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions |
Date: |
Tue, 18 Dec 2018 11:09:39 +0100 |
From: Daniel Henrique Barboza <address@hidden>
This patch updates the descriptions of 'guest-suspend-ram' and
'guest-suspend-hybrid' to mention that both commands relies now
on the proper support for wake up from suspend, retrieved by the
'wakeup-suspend-support' attribute of the 'query-current-machine'
QMP command.
Reported-by: Balamuruhan S <address@hidden>
Signed-off-by: Daniel Henrique Barboza <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Acked-by: Eduardo Habkost <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
---
qga/qapi-schema.json | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
index c6725b3ec8..a4ff5b8fc9 100644
--- a/qga/qapi-schema.json
+++ b/qga/qapi-schema.json
@@ -567,9 +567,11 @@
# For the best results it's strongly recommended to have the pm-utils
# package installed in the guest.
#
-# IMPORTANT: guest-suspend-ram requires QEMU to support the 'system_wakeup'
-# command. Thus, it's *required* to query QEMU for the presence of the
-# 'system_wakeup' command before issuing guest-suspend-ram.
+# IMPORTANT: guest-suspend-ram requires working wakeup support in
+# QEMU. You should check QMP command query-current-machine returns
+# wakeup-suspend-support: true before issuing this command. Failure in
+# doing so can result in a suspended guest that QEMU will not be able to
+# awaken, forcing the user to power cycle the guest to bring it back.
#
# This command does NOT return a response on success. There are two options
# to check for success:
@@ -594,9 +596,11 @@
#
# This command requires the pm-utils package to be installed in the guest.
#
-# IMPORTANT: guest-suspend-hybrid requires QEMU to support the 'system_wakeup'
-# command. Thus, it's *required* to query QEMU for the presence of the
-# 'system_wakeup' command before issuing guest-suspend-hybrid.
+# IMPORTANT: guest-suspend-hybrid requires working wakeup support in
+# QEMU. You should check QMP command query-current-machine returns
+# wakeup-suspend-support: true before issuing this command. Failure in
+# doing so can result in a suspended guest that QEMU will not be able to
+# awaken, forcing the user to power cycle the guest to bring it back.
#
# This command does NOT return a response on success. There are two options
# to check for success:
--
2.17.2
- [Qemu-devel] [PULL 0/7] QAPI patches for 2018-12-18, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 1/7] qapi: Turn ShutdownCause into QAPI enum, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 6/7] qmp hmp: Make system_wakeup check wake-up support and run state, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 5/7] qga: update guest-suspend-ram and guest-suspend-hybrid descriptions,
Markus Armbruster <=
- [Qemu-devel] [PULL 4/7] qmp: query-current-machine with wakeup-suspend-support, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 7/7] qapi: fix flat union on uncovered branches conditionals, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 3/7] qmp: Split ShutdownCause host-qmp into quit and system-reset, Markus Armbruster, 2018/12/18
- [Qemu-devel] [PULL 2/7] qmp: Add reason to SHUTDOWN and RESET events, Markus Armbruster, 2018/12/18
- Re: [Qemu-devel] [PULL 0/7] QAPI patches for 2018-12-18, Peter Maydell, 2018/12/19