[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 15/31] pcie: Allow generic PCIe root port to specify
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 15/31] pcie: Allow generic PCIe root port to specify link speed and width |
Date: |
Mon, 17 Dec 2018 23:17:43 -0500 |
From: Alex Williamson <address@hidden>
Allow users to experimentally specify speed and width values for the
generic PCIe root port. Defaults remain at 2.5GT/s & x1 for
compatiblity with the intent to only support changing defaults via
machine types for now.
Note for libvirt testing that pcie-root-port controllers are given
default names like "pci.7" which don't play well with using the
"-set device.$name.$prop=$value" options accessible to us via
<qemu:commandline> options. The solution is to add an <alias> to the
pcie-root-port <controller>, for example:
<controller type='pci' index='7' model='pcie-root-port'>
<model name='pcie-root-port'/>
<target chassis='7' port='0x15'/>
<alias name='ua-gfx0'/>
<address type='pci' domain='0x0000' bus='0x00' slot='0x02'
function='0x5'/>
</controller>
The "ua-" here is a mandatory prefix. We can then use:
<qemu:commandline>
<qemu:arg value='-set'/>
<qemu:arg value='device.ua-gfx0.x-speed=8'/>
<qemu:arg value='-set'/>
<qemu:arg value='device.ua-gfx0.x-width=16'/>
</qemu:commandline>
or, without an alias, set globals such as:
<qemu:commandline>
<qemu:arg value='-global'/>
<qemu:arg value='pcie-root-port.x-speed=8'/>
<qemu:arg value='-global'/>
<qemu:arg value='pcie-root-port.x-width=16'/>
</qemu:commandline>
Cc: Marcel Apfelbaum <address@hidden>
Tested-by: Geoffrey McRae <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci-bridge/gen_pcie_root_port.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/pci-bridge/gen_pcie_root_port.c
b/hw/pci-bridge/gen_pcie_root_port.c
index 299de429ec..ca5418a89d 100644
--- a/hw/pci-bridge/gen_pcie_root_port.c
+++ b/hw/pci-bridge/gen_pcie_root_port.c
@@ -124,6 +124,10 @@ static Property gen_rp_props[] = {
res_reserve.mem_pref_32, -1),
DEFINE_PROP_SIZE("pref64-reserve", GenPCIERootPort,
res_reserve.mem_pref_64, -1),
+ DEFINE_PROP_PCIE_LINK_SPEED("x-speed", PCIESlot,
+ speed, PCIE_LINK_SPEED_2_5),
+ DEFINE_PROP_PCIE_LINK_WIDTH("x-width", PCIESlot,
+ width, PCIE_LINK_WIDTH_1),
DEFINE_PROP_END_OF_LIST()
};
--
MST
- [Qemu-devel] [PULL 05/31] tests: Remove unused include, (continued)
- [Qemu-devel] [PULL 05/31] tests: Remove unused include, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 06/31] hw/smbios: Restrict access to "hw/smbios/ipmi.h", Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 07/31] hw/smbios: Remove "smbios_ipmi.h", Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 08/31] hw/smbios: Move to the hw/firmware/ subdirectory, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 09/31] hw/pci-bridge: Fix invalid free(), Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 10/31] pcie: Create enums for link speed and width, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 13/31] pcie: Add link speed and width fields to PCIESlot, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 11/31] pci: Sync PCIe downstream port LNKSTA on read, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 12/31] qapi: Define PCIe link speed and width properties, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 16/31] vfio/pci: Remove PCIe Link Status emulation, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 15/31] pcie: Allow generic PCIe root port to specify link speed and width,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 14/31] pcie: Fill PCIESlot link fields to support higher speeds and widths, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 17/31] pcie: Fast PCIe root ports for new machines, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 18/31] intel_iommu: dump correct iova when failed, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 19/31] intel_iommu: convert invalid traces into error reports, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 20/31] intel_iommu: dma read/write draining support, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 21/31] intel_iommu: remove "x-" prefix for "aw-bits", Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 22/31] intel_iommu: turn on IR by default, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 25/31] hw: i386: Use correct RSDT length for checksum, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 23/31] hw: acpi: The RSDP build API can return void, Michael S. Tsirkin, 2018/12/17
- [Qemu-devel] [PULL 26/31] hw: arm: Carry RSDP specific data through AcpiRsdpData, Michael S. Tsirkin, 2018/12/17