[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API |
Date: |
Fri, 14 Dec 2018 12:50:22 -0500 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Fri, Dec 14, 2018 at 12:08:22 -0500, Emilio G. Cota wrote:
> On Fri, Dec 14, 2018 at 15:57:32 +0000, Aaron Lindsay wrote:
(snip)
> > I added a function to the user-facing plugin API in my own version of
> > Pavel's plugin patchset to clear all existing plugin instrumentation,
(snip)
> I think the following API call would do what you need:
>
> typedef int (*qemu_plugin_reset_cb_t)(qemu_plugin_id_t id);
> void qemu_plugin_reset(qemu_plugin_id_t id, qemu_plugin_reset_cb_t cb);
>
> (or maybe qemu_plugin_reinstall?)
An alternative is to track the TBs that a plugin has inserted
instrumentation into, and only flush those. This would require
us to do an additional hash table insert when adding a
direct callback, but it allow us to avoid exporting tb_flush indirectly
to plugins, which could be abused by malicious plugins to perform
a DoS attack.
I'll look into this.
E.
- [Qemu-devel] [RFC v2 00/38] Plugin support, Emilio G. Cota, 2018/12/09
- [Qemu-devel] [RFC v2 02/38] tcg/README: fix typo s/afterwise/afterwards/, Emilio G. Cota, 2018/12/09
- [Qemu-devel] [RFC v2 03/38] cpu: introduce cpu_in_exclusive_work_context(), Emilio G. Cota, 2018/12/09
- [Qemu-devel] [RFC v2 01/38] trace: expand mem_info:size_shift to 3 bits, Emilio G. Cota, 2018/12/09
- [Qemu-devel] [RFC v2 04/38] translate-all: use cpu_in_exclusive_work_context() in tb_flush, Emilio G. Cota, 2018/12/09
- [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API, Emilio G. Cota, 2018/12/09
- Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API, Aaron Lindsay, 2018/12/14
- Re: [Qemu-devel] [RFC v2 05/38] plugin: add user-facing API, Emilio G. Cota, 2018/12/14
[Qemu-devel] [RFC v2 11/38] tcg: add tcg_gen_st_ptr, Emilio G. Cota, 2018/12/09
[Qemu-devel] [RFC v2 07/38] queue: add QTAILQ_REMOVE_SEVERAL, Emilio G. Cota, 2018/12/09
[Qemu-devel] [RFC v2 12/38] tcg: add MO_HADDR to TCGMemOp, Emilio G. Cota, 2018/12/09
[Qemu-devel] [RFC v2 06/38] plugin: add core code, Emilio G. Cota, 2018/12/09