[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages |
Date: |
Thu, 13 Dec 2018 15:22:10 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Am 13.12.2018 um 11:11 hat Daniel P. Berrangé geschrieben:
> On Wed, Dec 12, 2018 at 04:04:10PM -0600, Eric Blake wrote:
> > When a qemu-io command fails, it's best if the failure message
> > goes to stderr rather than stdout.
> >
> > Reported-by: Richard W.M. Jones <address@hidden>
> > Signed-off-by: Eric Blake <address@hidden>
> > ---
> >
> > RFC because at least iotest 60 (found by -qcow2 -g quick) breaks due
> > to reordering of output lines, and I'd rather know if we like this
> > idea before bothering to revisit all affected iotests (including
> > discovering if other slower ones have similar problems).
>
> I think the change is correct. Error messages should never go to stdout.
I'm not sure about this, to be honest. qemu-io is first and foremost an
interactive program, and spreading output across two streams, one
buffered and one unbuffered, in an interactive program feels like it has
to result in surprises.
Kevin
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, (continued)
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Eric Blake, 2018/12/12
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Daniel P . Berrangé, 2018/12/13
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Nir Soffer, 2018/12/13
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Eric Blake, 2018/12/13
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Nir Soffer, 2018/12/13
- Re: [Qemu-devel] [Qemu-block] [PATCH RFC] qemu-io: Prefer stderr for error messages, Nir Soffer, 2018/12/13
Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages, Daniel P . Berrangé, 2018/12/13
- Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages,
Kevin Wolf <=
Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages, Wainer dos Santos Moschetta, 2018/12/13
Re: [Qemu-devel] [PATCH RFC] qemu-io: Prefer stderr for error messages, Kevin Wolf, 2018/12/13