[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from vir
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci |
Date: |
Wed, 12 Dec 2018 18:43:45 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Laurent Vivier <address@hidden> wrote:
> On 26/11/2018 20:59, Juan Quintela wrote:
>> Signed-off-by: Juan Quintela <address@hidden>
>>
>> ---
>>
>> Remove the "contributions after" clause. This is based on
>>
>> commit 59ccd20a9ac719cff82180429458728f03ec612f
>> Author: KONRAD Frederic <address@hidden>
>> Date: Wed Apr 24 10:07:56 2013 +0200
>> ---
>> hw/virtio/Makefile.objs | 1 +
>> hw/virtio/virtio-pci.c | 52 -----------------------
>> hw/virtio/virtio-pci.h | 14 -------
>> hw/virtio/virtio-rng-pci.c | 86 ++++++++++++++++++++++++++++++++++++++
>> tests/Makefile.include | 1 +
>> 5 files changed, 88 insertions(+), 66 deletions(-)
>> create mode 100644 hw/virtio/virtio-rng-pci.c
> ...
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index fb0b449c02..e8235890ec 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -149,6 +149,7 @@ check-qtest-virtio-y += tests/virtio-net-test$(EXESUF)
>> check-qtest-virtio-y += tests/virtio-balloon-test$(EXESUF)
>> check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF)
>> check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF)
>> +check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF)
>
> I think you should remove the line just above.
>
> except that:
Done.
Thanks.
>
> Reviewed-by: Laurent Vivier <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v2 04/16] virtio: split virtio rng bits from virtio-pci,
Juan Quintela <=