[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/6] rdma: check num_sge does not exceed MAX_
From: |
Yuval Shaia |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/6] rdma: check num_sge does not exceed MAX_SGE |
Date: |
Wed, 12 Dec 2018 18:56:11 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Dec 12, 2018 at 05:17:21PM +0530, P J P wrote:
> From: Prasad J Pandit <address@hidden>
>
> rdma back-end has scatter/gather array ibv_sge[MAX_SGE=4] set
> to have 4 elements. A guest could send a 'PvrdmaSqWqe' ring element
> with 'num_sge' set to > MAX_SGE, which may lead to OOB access issue.
> Add check to avoid it.
>
> Reported-by: Saar Amar <address@hidden>
> Signed-off-by: Prasad J Pandit <address@hidden>
> ---
> hw/rdma/rdma_backend.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> Update v1: use new error code VENDOR_ERR_INV_NUM_SGE
> -> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02220.html
>
> diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
> index ae1e4dcb29..bd4710d16f 100644
> --- a/hw/rdma/rdma_backend.c
> +++ b/hw/rdma/rdma_backend.c
> @@ -476,9 +476,9 @@ void rdma_backend_post_send(RdmaBackendDev *backend_dev,
> }
>
> pr_dbg("num_sge=%d\n", num_sge);
> - if (!num_sge) {
> - pr_dbg("num_sge=0\n");
> - complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
> + if (!num_sge || num_sge > MAX_SGE) {
> + pr_dbg("invalid num_sge=%d\n", num_sge);
> + complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
> return;
> }
>
> @@ -603,9 +603,9 @@ void rdma_backend_post_recv(RdmaBackendDev *backend_dev,
> }
>
> pr_dbg("num_sge=%d\n", num_sge);
> - if (!num_sge) {
> - pr_dbg("num_sge=0\n");
> - complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_NO_SGE, ctx);
> + if (!num_sge || num_sge > MAX_SGE) {
> + pr_dbg("invalid num_sge=%d\n", num_sge);
> + complete_work(IBV_WC_GENERAL_ERR, VENDOR_ERR_INV_NUM_SGE, ctx);
> return;
> }
Reviewed-by: Yuval Shaia <address@hidden>
>
> --
> 2.19.2
>
- [Qemu-devel] [PATCH v1 0/6] rdma: various issues in rdma/pvrdma backend, P J P, 2018/12/12
- [Qemu-devel] [PATCH v1 3/6] pvrdma: check number of pages when creating rings, P J P, 2018/12/12
- [Qemu-devel] [PATCH v1 2/6] pvrdma: add uar_read routine, P J P, 2018/12/12
- [Qemu-devel] [PATCH v1 1/6] rdma: check num_sge does not exceed MAX_SGE, P J P, 2018/12/12
- Re: [Qemu-devel] [PATCH v1 1/6] rdma: check num_sge does not exceed MAX_SGE,
Yuval Shaia <=
- [Qemu-devel] [PATCH v1 4/6] pvrdma: release ring object in case of an error, P J P, 2018/12/12
- [Qemu-devel] [PATCH v1 6/6] rdma: remove unused VENDOR_ERR_NO_SGE macro, P J P, 2018/12/12
- [Qemu-devel] [PATCH v1 5/6] pvrdma: check return value from pvrdma_idx_ring_has_ routines, P J P, 2018/12/12