[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed ho
From: |
Mark Cave-Ayland |
Subject: |
Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook |
Date: |
Tue, 11 Dec 2018 19:13:13 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 10/12/2018 16:56, Peter Maydell wrote:
> This patchset converts the m68k target from the deprecated
> unassigned_access hook to the new transaction_failed hook.
> It's RFC for a couple of reasons:
> * it's untested, since I don't have an m68k test image
> * the second patch just makes "bus error while trying to
> read page tables" be treated as a page fault, when it
> should probably cause a fault reporting it as a bus error
> of some kind
> * I don't understand why the old unassigned_access hook
> set the ATC bit in the MMU SSW, since the docs I have say
> this should be set if the fault happened during a table
> search, but cleared if it's just an ordinary bus-errored
> data or insn access. Probably this is a pre-existing bug?
>
> Anyway, I send it out as a skeleton for comments, because
> it would be nice to get rid of the old unassigned_access
> hook, which is fundamentally broken (it's still used by m68k,
> microblaze, mips and sparc).
Laurent is really the expert here (my work on the q800 was purely on the device
side), however is this also a nudge to see if the unassigned_access hook can be
eliminated from sparc too? ;)
ATB,
Mark.
- [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook, Peter Maydell, 2018/12/10
- [Qemu-devel] [RFC 3/3] target/m68k: Switch to transaction_failed hook, Peter Maydell, 2018/12/10
- [Qemu-devel] [RFC 1/3] target/m68k: In dump_address_map() check for memory access failures, Peter Maydell, 2018/12/10
- [Qemu-devel] [RFC 2/3] target/m68k: In get_physical_address() check for memory access failures, Peter Maydell, 2018/12/10
- Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook, Thomas Huth, 2018/12/11
- Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook,
Mark Cave-Ayland <=
- Re: [Qemu-devel] [RFC 0/3] target/m68k: convert to transaction_failed hook, Laurent Vivier, 2018/12/12