Re: [Qemu-devel] [PATCH 02/14] nbd/client: More consistent error messages

[Eric Blake]

On 12/5/18 9:03 AM, Vladimir Sementsov-Ogievskiy wrote:
> 01.12.2018 1:03, Eric Blake wrote:
> > Consolidate on using decimal (not hex) and on outputting the
> > option reply name (not just value) when the client reports
> > protocol discrepancies from the server.  While it won't affect
> > normal operation, it makes debugging additions easier.
> >
> > Signed-off-by: Eric Blake <address@hidden>
> > ---

> > +        error_setg(errp, "Unexpected option type %u (%s) expected %u (%s)",
> > +                   reply->option, nbd_opt_lookup(reply->option),
> > +                   opt, nbd_opt_lookup(opt));

> > @@ -378,9 +380,9 @@ static int nbd_opt_go(QIOChannel *ioc, const char *wantname,
> >                return 1;
> >            }
> >            if (reply.type != NBD_REP_INFO) {
> > -            error_setg(errp, "unexpected reply type %" PRIu32
> > -                       " (%s), expected %u",
> > -                       reply.type, nbd_rep_lookup(reply.type), NBD_REP_INFO);
> > +            error_setg(errp, "unexpected reply type %u (%s), expected %u (%s)",
>
> hmm, we are definitely inconsistent about having comma before "expected" word...
>
> anyway,
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

That's minor enough; I'll add commas to all instances, but keep your R-b.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org