[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing feature
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/i386: Fixes to the check missing features routine |
|
Date: |
Fri, 7 Dec 2018 16:26:30 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 12/7/18 4:14 PM, Wainer dos Santos Moschetta wrote:
The x86_cpu_class_check_missing_features() returns a list
of unavailable features compared to the host CPU. Currently it may
return empty strings for unamed features as well as duplicated
s/unamed/unnamed/
names.
For example, the qmp "query-cpu-definitions" below shows one empty
string and repeated "mpx" entries:
+++ b/target/i386/cpu.c
@@ -3615,19 +3615,29 @@ static void
x86_cpu_class_check_missing_features(X86CPUClass *xcc,
x86_cpu_filter_features(xc);
+ /* Uses an auxiliar dictionary to ensure the list of features has not
s/auxiliar/auxiliary/
+ repeated name. */
+ QDict *unique_feats_dict = qdict_new();
+
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org